Add support for configurable timeout #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could make use of a configurable timeout, too. @acouvreur what needs to be done, to get this PR merged? Do you need help here? |
I'll add the missing documentation and then we're good to go |
|
Closing in favor of #16 |
acouvreur
added a commit
that referenced
this pull request
Mar 7, 2023
* Add support for configurable timeout * add documentation about timeoutMillis config --------- Co-authored-by: Antonio Macrì <ing.antonio.macri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have some use cases where the backend responds in several seconds (e.g. it is building a zip file).
This PR allows to set a timeout in the config and uses it instead of the hardcoded value of 2 seconds.