Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit body buffering to avoid resource exhaustion #8

Conversation

Enrico204
Copy link
Contributor

This PR implement a limit for body buffering in order to avoid resource exhaustion using a very large body (see #7). The default limit is 10MB (which should be enough for non-uploads requests), but it's configurable.

@acouvreur
Copy link
Owner

Awesome, although you should specify the new option in the .traefik,yaml file

testData:
ModsecurityUrl: http://waf:80

And probably add a documentation about it, the default value and the reason inside the readme.

Thank you very much for this!

@Enrico204
Copy link
Contributor Author

Done! 👍
(this is the first time I see the code for a traefik plugin)

I took the liberty of adding a new section in the README, named "Configuration", showing both the configuration parameters. I also added the configuration for maxBodySize inside the docker-compose files and the traefik YAML.

Let me know if you have any comment :-)

@acouvreur acouvreur merged commit bf893e0 into acouvreur:main Aug 7, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Enrico204 Enrico204 deleted the limit-body-buffering-to-avoid-resource-exhaustion branch August 8, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants