Interpreter: Remove temporary code for External() opcode

The interpreter should never see this opcode (it is used by disassemblers), so the final implementation is to return an error.
acpica · May 3, 2016 · f2d349f · f2d349f
1 parent 59e0aaa
commit f2d349f
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/source/components/dispatcher/dsutils.c b/source/components/dispatcher/dsutils.c
@@ -675,12 +675,14 @@ AcpiDsCreateOperand (
                 }
                 else if (ParentOp->Common.AmlOpcode == AML_EXTERNAL_OP)
                 {
-                    /* TBD: May only be temporary */
-
-                    ObjDesc = AcpiUtCreateStringObject ((ACPI_SIZE) NameLength);
-
-                    strncpy (ObjDesc->String.Pointer, NameString, NameLength);
-                    Status = AE_OK;
+                    /*
+                     * This opcode should never appear here. It is used only
+                     * by AML disassemblers and is surrounded by an If(0)
+                     * by the ASL compiler.
+                     *
+                     * Therefore, if we see it here, it is a serious error.
+                     */
+                    Status = AE_AML_BAD_OPCODE;
                 }
                 else
                 {