Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BioXAS Mirrors #2441

Open
1 of 4 tasks
helfrij opened this issue Jul 14, 2016 · 0 comments
Open
1 of 4 tasks

BioXAS Mirrors #2441

helfrij opened this issue Jul 14, 2016 · 0 comments

Comments

@helfrij
Copy link
Contributor

helfrij commented Jul 14, 2016

There are a couple of things that need to be addressed for improved control of the M1 and M2 mirrors on all three BioXAS beamlines. Here are some ideas based on yesterday's discussion:

  • Identify steps required to move each mirror pseudomotor control reliably/repeatably. (David B, BioXAS team)
  • Implement steps required to move each mirror pseudomotor control. (eg. move pitch = lower height, move pitch, raise height). (David B)
  • Implement steps required to manipulate the mirror bend. (David B).
  • 'Stop and lock' capability--stop a motor and prevent all motion until someone comes to 'unlock' it. This could act as a safety. (David B)
  • Detect when a motor/pseudomotor has left an acceptable range of values, the range likely dependant on the positions of other components, and halt motion. (David B)

Additionally, there are some internal simplifications/refactors that can be done:

  • Create editor for mirror pseudomotors that displays both the control setpoint and feedback values.
  • Eventually, will need new view for the mirrors that will allow for the roll, pitch, height, yaw for a single move to be specified, and then executed. A giant control editor, sort of.
  • No need to separate out mirror mask controls into their own class. Can bring those motors into BioXASMirror.
  • Can consolidate some mirror views, no need to have separate views for M1 and M2. Can have a single BioXASMirrorView that can display information for a general BioXASMirror and display the information the mirror can provide.

I've grouped some of the existing issues for the mirrors together into this Epic--they may be modified/updated depending on this list of needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant