Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow to skip the commands on sites which are under maintenance #121

Open
nikunjkotecha opened this issue Nov 28, 2020 · 2 comments

Comments

@nikunjkotecha
Copy link

Add a flag in commands like sfml and sfmlc to filter the sites under maintenance

Example: drush sfml status --maintenance-check

Example purposes:

  • We want to sync data from external system for only the sites which are live
  • We want to generate sitemap for only the sites which are live
@vbouchet31
Copy link
Contributor

I am wondering if we should do something more generic as there is already multiple exclude options. Should we have an argument which is a php-eval argument and so is executed on each site before executing the acsf-tools-ml (or acsf-tools-mlc) command.

Something like drush acsf-tools-ml sapi-i my_index --exclude-query="cget maintenance_mode" --exclude-result="1" (this is really just an example argument name/format/... can vary, it just to show the idea of generic argument). I am not sure how easy it would be to implement something generic enough to allow cget and sqlq at least.

@sdelbosc
Copy link
Contributor

Supporting quotes properly is already a pain in normal case so I am afraid that eval here would be even worse. I think I would stick to initial suggestion from Nikunj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants