Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream issues with Drupal Check Library #3743

Closed
mikemadison13 opened this issue Jul 8, 2019 · 3 comments
Closed

Upstream issues with Drupal Check Library #3743

mikemadison13 opened this issue Jul 8, 2019 · 3 comments
Labels
Awaiting response Maintainer needs more info Bug Something isn't working

Comments

@mikemadison13
Copy link
Contributor

mikemadison13 commented Jul 8, 2019

Describe the bug
see mglaman/drupal-check#95

currently there is an issue between drupal-check and phpstan, which is preventing the deprecation scans from functioning.

To Reproduce
enable deprecation scans and run blt validate

Expected behavior
the code runs w/o error

Detailed error output

PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function PHPStan\Command\AnalyseApplication::analyse(), 6 passed in /vendor/mglaman/drupal-check/src/Command/CheckCommand.php on line 175 and exactly 7 expected in /vendor/phpstan/phpstan/src/Command/AnalyseApplication.php:51
Stack trace:
#0 /vendor/mglaman/drupal-check/src/Command/CheckCommand.php(175): PHPStan\Command\AnalyseApplication->analyse(Array, false, Object(PHPStan\Command\ErrorsConsoleStyle), Object(PHPStan\Command\ErrorFormatter\TableErrorFormatter), false, false)
#1 /vendor/symfony/console/Command/Command.php(255): DrupalCheck\Command\CheckCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#2 /vendor/symfony/console/Application.php(969): Symfony\Component\Console\Command\Command->run(Object(Symfony\Comp in /vendor/phpstan/phpstan/src/Command/AnalyseApplication.php on line 51

Fatal error: Uncaught ArgumentCountError: Too few arguments to function PHPStan\Command\AnalyseApplication::analyse(), 6 passed in /vendor/mglaman/drupal-check/src/Command/CheckCommand.php on line 175 and exactly 7 expected in /vendor/phpstan/phpstan/src/Command/AnalyseApplication.php:51
Stack trace:
#0 /vendor/mglaman/drupal-check/src/Command/CheckCommand.php(175): PHPStan\Command\AnalyseApplication->analyse(Array, false, Object(PHPStan\Command\ErrorsConsoleStyle), Object(PHPStan\Command\ErrorFormatter\TableErrorFormatter), false, false)
#1 /vendor/symfony/console/Command/Command.php(255): DrupalCheck\Command\CheckCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#2 /vendor/symfony/console/Application.php(969): Symfony\Component\Console\Command\Command->run(Object(Symfony\Comp in /vendor/phpstan/phpstan/src/Command/AnalyseApplication.php on line 51

System information

  • BLT version: 10.2.0

Additional context
Only occurs if set in blt.yml:

validate:
  deprecation:
    modules: true
    themes: true
@mikemadison13 mikemadison13 added Bug Something isn't working 10.x labels Jul 8, 2019
@danepowell
Copy link
Contributor

Could be related to the fatal errors mentioned here: #3739

@danepowell
Copy link
Contributor

@mikemadison13 I can't reproduce this, might it have been fixed upstream? If you run composer update.

@danepowell danepowell added the Awaiting response Maintainer needs more info label Jul 10, 2019
@no-response
Copy link

no-response bot commented Jul 24, 2019

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@no-response no-response bot closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting response Maintainer needs more info Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants