Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PHP and Drupal error logging #4703

Open
grasmash opened this issue Oct 17, 2023 · 1 comment
Open

Respect PHP and Drupal error logging #4703

grasmash opened this issue Oct 17, 2023 · 1 comment
Labels
Enhancement A feature or feature request

Comments

@grasmash
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I found it very confusing that despite configuring both Drupal and PHP to NOT display deprecation warnings, I continued to see them locally. I wasted a good bit of time discovering https://github.com/acquia/blt/blob/main/settings/logging.settings.php#L18 which completely overrides those settings. This feels a bit heavy handed.

Describe the solution you'd like
At the least, prominently document this behavior. Ideally it should be displayed at run time in the error log. If I saw a notice in the error log that said something like "BLT has set error_reporting to E_ALL" then I would have resolved the issue much faster.

Describe alternatives you've considered
Alternatively, we could just stop overriding the error level.

@grasmash grasmash added the Enhancement A feature or feature request label Oct 17, 2023
@grasmash
Copy link
Contributor Author

This would be good:

error_log("BLT is overriding the error_reporting, display_errors, and display_startup_errors settings in logging.settings.php.");

But only if it doesn't execute for every single PHP process. Not sure if there's away to do it less frequently, like only when cache is cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

1 participant