Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoring phase bug - acceptance not registered #101

Closed
alexmitrani opened this issue Mar 18, 2021 · 2 comments
Closed

Scoring phase bug - acceptance not registered #101

alexmitrani opened this issue Mar 18, 2021 · 2 comments

Comments

@alexmitrani
Copy link

alexmitrani commented Mar 18, 2021

In scoring phase, in the app it says it is "my turn"...

Screenshot_20210318-090852

... and that neither player has accepted.

Screenshot_20210318-085858

However, I have accepted and it is the other player who has not accepted:

Screenshot_20210318-085953

It shouldn't say that it is my turn unless I haven't accepted. Perhaps the root of the issue here is that it does not recognise that I have accepted?

Also, tapping the yellow "accept" button in the app did not seem to do anything, so I accepted the score on OGS.

Thanks

@teapoweredrobot
Copy link

I noticed another issue with the scoring phase thing today. Not linked to this bug but I didn't think it deserved it's own entry.
I was in the scoring phase of a game and wanted to go to the game on browser. But the scoring phase things stay on the screen and block the menu button. I tapped X (having previously accepted the board state) but that has the effect of restarting the game with opponent's turn.
I think the scoring phase buttons should go away when you accept. There could be a menu item to get them back if necessary.

@acristescu
Copy link
Owner

With the rewrite, both issues are no longer there: games are no longer shown as your turn if you accepted the current state and also you can open the game in the browser during the scoring phase because the link is now in the overflow menu to the top right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants