Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jest tests #48

Closed
Tracked by #59
acrosman opened this issue Jun 28, 2021 · 3 comments · Fixed by #49
Closed
Tracked by #59

Add Jest tests #48

acrosman opened this issue Jun 28, 2021 · 3 comments · Fixed by #49
Labels
enhancement New feature or request help wanted Extra attention is needed Release Issues and PRs that are related to next release testing Related to automated testing

Comments

@acrosman
Copy link
Owner

Summary
We need automated testing. Since Jest is SFDC's library of choice seems like the right choice here.

@acrosman acrosman added enhancement New feature or request help wanted Extra attention is needed labels Jun 28, 2021
@acrosman acrosman added the testing Related to automated testing label Jul 3, 2021
@acrosman acrosman mentioned this issue Jul 18, 2021
5 tasks
@acrosman acrosman added the Release Issues and PRs that are related to next release label Jul 18, 2021
@imrishabh18
Copy link
Contributor

Hey @acrosman! Can you give more context on this pls? I would like to take this up

@acrosman
Copy link
Owner Author

#49 (which I'm going to merge sometime today -- once I get the last of the new checks to pass) will put the initial pieces in place. Once that's done I'll replace this issue with a few that are more fine grained about where there are gaps in test coverage (there is very little coverage at the moment), and where the tests to need new features.

The big challenge on this project is writing tests that work with Electron and Knex in a useful way (either via mocks or additional dependencies.

But given that there is very little coverage now there is lots of low handing fruit in all parts of the project. #49 provides several commits near the end that outline a few ways to setup tests for the sf_calls.js module, but again any tests on any part of the application are welcome.

@acrosman acrosman mentioned this issue Jul 24, 2021
7 tasks
@acrosman
Copy link
Owner Author

@imrishabh18 you might review #63 for suggestions on next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed Release Issues and PRs that are related to next release testing Related to automated testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants