Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values aren't consistently being set properly. #80

Closed
acrosman opened this issue Aug 18, 2021 · 5 comments
Closed

Default values aren't consistently being set properly. #80

acrosman opened this issue Aug 18, 2021 · 5 comments
Labels
bug Something isn't working question Further information is requested

Comments

@acrosman
Copy link
Owner

My default values aren't being set properly. Defaults for Varchar(255)s are set without being enclosed in single quotes, so they aren't quite working in practice.
image

Originally posted by @allisonletts in #30 (comment)

@acrosman acrosman added the bug Something isn't working label Aug 18, 2021
@allisonletts
Copy link
Contributor

I'm running MariaDB through HeidiSQL.

@acrosman
Copy link
Owner Author

I'm also wonder about the field settings for that specific field. From the screen shot it looks like other were set differently right around it so I'd like to know what that one includes to see why it's different.

@allisonletts
Copy link
Contributor

the DEFAULT '0' is for a TinyInt -- is that what you're looking at?

@acrosman
Copy link
Owner Author

I'm not able to reproduce this at the moment. I did notice that it's not properly pulling defaults for all fields, but I'm not sure if the fix I just posted to #85 is correct for that or for this. Would appreciate re-testing with that branch to see if it behaves better (also should be much faster than release v0.4.0 so the testing should be too bad).

@acrosman acrosman added the question Further information is requested label Aug 21, 2021
@allisonletts
Copy link
Contributor

This can be closed for now as a pebkac, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants