Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [N-02] Incomplete Event Emissions #327

Merged
merged 1 commit into from Jul 28, 2023
Merged

fix: [N-02] Incomplete Event Emissions #327

merged 1 commit into from Jul 28, 2023

Conversation

mrice32
Copy link
Contributor

@mrice32 mrice32 commented Jul 27, 2023

No description provided.

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -35,7 +35,7 @@ contract ZkSync_SpokePool is SpokePool {
// Bridge used to withdraw ERC20's to L1
ZkBridgeLike public zkErc20Bridge;

event SetZkBridge(address indexed erc20Bridge);
event SetZkBridge(address indexed erc20Bridge, address indexed oldErc20Bridge);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@mrice32 mrice32 merged commit 69fa759 into master Jul 28, 2023
5 checks passed
@mrice32 mrice32 deleted the n_02 branch July 28, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants