Skip to content

Commit

Permalink
fix: [N-06] TODO Comments (#325)
Browse files Browse the repository at this point in the history
* fix: [N02] Add docstring

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* fix: [N-06] TODO Comments

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

---------

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
  • Loading branch information
mrice32 committed Jul 28, 2023
1 parent 7886269 commit d45b820
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
3 changes: 0 additions & 3 deletions contracts/ZkSync_SpokePool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ interface ZkBridgeLike {
) external;
}

// TODO: Find the mainnet source code, can't seem to find it in here:
// https://github.com/matter-labs/era-contracts/blob/6391c0d7bf6184d7f6718060e3991ba6f0efe4a7/zksync/contracts
// https://github.com/matter-labs/v2-testnet-contracts/blob/main/l2/system-contracts/L2EthToken.sol#L74
interface IL2ETH {
function withdraw(address _l1Receiver) external payable;
}
Expand Down
3 changes: 1 addition & 2 deletions contracts/chain-adapters/ZkSync_Adapter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@ contract ZkSync_Adapter is AdapterInterface {
// Bridges to send ERC20 and ETH to L2. Fetchable via `zks_getBridgeContracts` method on JSON RPC.
ZkBridgeLike public constant zkErc20Bridge = ZkBridgeLike(0x57891966931Eb4Bb6FB81430E6cE0A03AAbDe063);

// Set l1Weth at construction time to make testing easier. TODO: Think of some way to be able to hardcode this
// while keeping unit tests easy to write with custom WETH that we can mint/transfer.
// Set l1Weth at construction time to make testing easier.
WETH9Interface public immutable l1Weth;

event ZkSyncMessageRelayed(bytes32 canonicalTxHash);
Expand Down

0 comments on commit d45b820

Please sign in to comment.