fix: [N-03] Lack of Documentation (removed hardcoded refund address) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
pxrl
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Nice improvement to make it configurable via the constructor.
I've proposed a PR to update the tests so they verify that the output l2RefundAddress matches the what was supplied in the constructor. I couldn't propose it directly on this PR because it's not the scope of the diff. See #329
james-a-morris
approved these changes
Jul 28, 2023
| */ | ||
| constructor(WETH9Interface _l1Weth) { | ||
| constructor(WETH9Interface _l1Weth, address _l2RefundAddress) { |
There was a problem hiding this comment.
Good call on making this dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardcoded refund address for zkSync, replaces it with an immutable value, and adds a default address in the deployment script that is the most common dataworker address.