Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when first line of test module contains docstring !< #10

Closed
DaanVanVugt opened this issue Aug 3, 2016 · 3 comments
Closed

Error when first line of test module contains docstring !< #10

DaanVanVugt opened this issue Aug 3, 2016 · 3 comments

Comments

@DaanVanVugt
Copy link

Hi,

I ran into a weird error when using FRUITPy: If the first line (before module) contains a comment (of the form !<, I did not test others), the generated test driver will have a line

use contains

which causes some issues because I do not have a module named contains

Daan

ps. Thanks for making FRUITPy, it made my life a bit easier :)

@acroucher
Copy link
Owner

hi Daan, thanks for reporting that.

Am I right in suspecting that your comment included the words 'module contains'? There was a bug in parse_test_module_name() which meant it would fail if there was a comment before the start of the module, which had the word 'module' in it.

I have just pushed a fix to the FRUITPy testing branch. Can you try that and let me know if it fixes your problem?

@DaanVanVugt
Copy link
Author

Hi Adrian,

Yes you are completely right.
The newest testing branch seems to work just fine.

Thanks,
Daan

On Thu, Aug 4, 2016 at 3:24 AM, Adrian Croucher notifications@github.com
wrote:

hi Daan, thanks for reporting that.

Am I right in suspecting that your comment included the words 'module
contains'? There was a bug in parse_test_module_name() which meant it would
fail if there was a comment before the start of the module, which had the
word 'module' in it.

I have just pushed a fix to the FRUITPy testing branch. Can you try that
and let me know if it fixes your problem?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACMaOmZwkkidqpeZmRhMkLUGTE8eWvfks5qcT9GgaJpZM4JbtC8
.

@acroucher
Copy link
Owner

Great. I've just merged that fix into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants