Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Adding OIDC Config , Helm chart errors out #24

Closed
usr-av opened this issue Aug 25, 2021 · 2 comments
Closed

On Adding OIDC Config , Helm chart errors out #24

usr-av opened this issue Aug 25, 2021 · 2 comments

Comments

@usr-av
Copy link

usr-av commented Aug 25, 2021

how to reproduce -

datahub-frontend:
...
  extraEnvs:
    - name: AUTH_OIDC_ENABLED
      value: true
    - name: AUTH_OIDC_CLIENT_ID
      value: "<change-me>"
    - name: AUTH_OIDC_CLIENT_SECRET
      value: "<change-me>"
    - name: AUTH_OIDC_DISCOVERY_URI
      value: "<change-me>"
    - name: AUTH_OIDC_BASE_URL
      value: "<change-me>"
helm install datahub datahub/datahub --values ./charts/datahub/values.yaml -n datahub

Error: Deployment in version "v1" cannot be handled as a Deployment: v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found t, error found in #10 byte of ...|,"value":true},{"nam|..., bigger context ...|geEvent_v1"},{"name":"AUTH_OIDC_ENABLED","value":true},{"name":"AUTH_OIDC_CLIENT_ID","value":"f8bcbc|...

i believe , toYaml loosing double quote to be the issue

https://github.com/acryldata/datahub-helm/blob/master/charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml#L141

@gcaride
Copy link

gcaride commented Sep 1, 2021

Hi, same issue here!

Put true in quotes.

This is in my case with Google Auth

datahub-frontend:
...
  extraEnvs:
    - name: AUTH_OIDC_ENABLED
      value: "true"
    - name: AUTH_OIDC_CLIENT_ID
      value: "<change-me>"
    - name: AUTH_OIDC_CLIENT_SECRET
      value: "<change-me>"
    - name: AUTH_OIDC_DISCOVERY_URI
      value: "<change-me>"
    - name: AUTH_OIDC_BASE_URL
      value: "<change-me>"
    - name: AUTH_OIDC_SCOP
      value: "openid profile email"
    - name: AUTH_OIDC_USER_NAME_CLAIM
      value: "email"
    - name: AUTH_OIDC_USER_NAME_CLAIM_REGEX
      value: ([^@]+)

@usr-av
Copy link
Author

usr-av commented Sep 17, 2021

thanks @gcaride , that worked.

@usr-av usr-av closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants