Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for poster image aspect ratio and issue with shrinking of larger poster images #15

Open
JesseHC opened this issue Mar 22, 2023 · 2 comments

Comments

@JesseHC
Copy link

JesseHC commented Mar 22, 2023

This is related to Aspect ratio not being honored for video player sidecar poster images, but I figured you would want me to post it here and not mix things up.

I know you are planning on getting rid of mediaelementjs_player, but if you change line 112 in mediaelementplayer.css from:
background-size: cover;
to:
background-size: contain;

It will properly scale the image posters in that as well to their correct aspect ratio in the video player.

The one issue I have noticed with mediaelementjs_player and how it handles poster images (and this may relate eventually to Zenphoto as well), if the image is larger than the set poster size, but a different aspect ratio, it will stretch the image when it shrinks it. This is not a problem if the images are smaller, it will keep them at the smaller size, and scale them in the player itself.

So a 1440x1080 sidecar image gets stretched to 1280x720, but a 640x480 image will stay at 640x480.

@acrylian
Copy link
Owner

Please note: The repo is not set into archive mode because I forgot but - as noted in the readme – it is not developed anymore.

@acrylian
Copy link
Owner

Btw, the file in question is from the player itself. We don't modify parts of 3rd party scripts generally because that gets overwritten on updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants