Skip to content
This repository has been archived by the owner on Jul 26, 2019. It is now read-only.

Videos will not play if zp_picturefill is enabled on image.php #12

Open
JatB opened this issue Feb 14, 2018 · 1 comment
Open

Videos will not play if zp_picturefill is enabled on image.php #12

JatB opened this issue Feb 14, 2018 · 1 comment

Comments

@JatB
Copy link

JatB commented Feb 14, 2018

Media players will not work for video files if zp_picturefill is enabled on image.php (Which is where I think you would want it to actually run half the time, that and on thumbnails.)

If the default-
printDefaultSizedImage(getImageTitle());

is changed to zp_picturefill-
printHDDefaultSizedImage(null, true);

Videos will not load. This might seem obvious, but it took me a few minutes to figure out, and there is no warning in the readme. I tested it with the default jplayer on the current build.

@acrylian
Copy link
Owner

acrylian commented Feb 14, 2018

There is no warning because none of the players use the functions by this plugin. This plugin also does not add anything automatically, you have to add the functions manually to your theme.

I forgot to label it but this plugin and is especially its HD functions are not developed anymore. Much better functionality (see also the other ticket) will be built into the core the next major release in the future (before you ask, no release date yet).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants