Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] click-odoo-update: exclude tests from checksum #125

Merged
merged 1 commit into from Aug 28, 2023

Conversation

ThomasBinsfeld
Copy link
Member

A modification in tests alone should not require a database upgrade.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #125 (751f887) into master (1c15e02) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 751f887 differs from pull request most recent head c3998c8. Consider uploading reports for the commit c3998c8 to get more accurate results

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files          13       13           
  Lines         873      873           
  Branches      187      187           
=======================================
  Hits          812      812           
  Misses         42       42           
  Partials       19       19           
Impacted Files Coverage Δ
click_odoo_contrib/update.py 87.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbidoul
Copy link
Member

sbidoul commented Nov 25, 2022

Looks good. Strictly speaking it's a breaking change, but I don't think it will be an issue in practice.
Can you add a newsfragment/125.feature with a changelog entry?

@ThomasBinsfeld ThomasBinsfeld force-pushed the imp_click_odoo_update_exclude_tests_tbi branch from 751f887 to ed74bea Compare November 25, 2022 10:46
A modification in tests alone should not require a database upgrade
@ThomasBinsfeld ThomasBinsfeld force-pushed the imp_click_odoo_update_exclude_tests_tbi branch from ed74bea to c3998c8 Compare November 25, 2022 10:48
@ThomasBinsfeld
Copy link
Member Author

Looks good. Strictly speaking it's a breaking change, but I don't think it will be an issue in practice.

All checksums will need a recomputation indeed. Meaning click-odoo-update will update all modules once this change is applied.

Can you add a newsfragment/125.feature with a changelog entry?

Done

Copy link
Contributor

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@sbidoul sbidoul merged commit 96b0008 into master Aug 28, 2023
@sbidoul sbidoul deleted the imp_click_odoo_update_exclude_tests_tbi branch August 28, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants