[IMP] manifest: add category property #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
Oct 30, 2023
src/manifestoo_core/addon.py
Outdated
| @@ -53,6 +53,7 @@ def from_addon_dir( | |||
| cls, | |||
| addon_dir: Path, | |||
| allow_not_installable: bool = False, | |||
| addons_categories: Optional[List[str]] = None, | |||
There was a problem hiding this comment.
I don't think this kind of filtering belongs here, because we can imagine an infinity of different such filters.
Let's keep that in manifestoo for now.
sbidoul
reviewed
Oct 30, 2023
| @@ -128,6 +128,10 @@ def license(self) -> Optional[str]: | |||
| def author(self) -> Optional[str]: | |||
| return self._get("author", _check_optional_str, default=None) | |||
|
|
|||
| @property | |||
| def category(self) -> Optional[str]: | |||
| return self._get("category", _check_optional_str, default=None) | |||
ThomasBinsfeld
force-pushed
the
imp_manifestoo_core_addons_set_categories_tbi
branch
from
788575c
to
27ad10f
Compare
ThomasBinsfeld
changed the title
|
Done |
sbidoul
reviewed
Oct 30, 2023
| @@ -136,3 +136,6 @@ dmypy.json | |||
|
|
|||
| # Cython debug symbols | |||
| cython_debug/ | |||
|
|
|||
| # pycharm dev env | |||
| .idea/ | |||
There was a problem hiding this comment.
Tip: add this to your ~/.gitconfig
[core]
excludesfile = ~/.gitignore
sbidoul
approved these changes
Oct 30, 2023
sbidoul
force-pushed
the
imp_manifestoo_core_addons_set_categories_tbi
branch
from
27ad10f
to
8883e82
Compare
sbidoul
force-pushed
the
imp_manifestoo_core_addons_set_categories_tbi
branch
from
8883e82
to
21e8f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the category property in manifest.