Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some video examples should have audio, but they do not [1ec09b] #1620

Closed
WilcoFiers opened this issue May 26, 2021 · 6 comments · Fixed by #1680
Closed

Some video examples should have audio, but they do not [1ec09b] #1620

WilcoFiers opened this issue May 26, 2021 · 6 comments · Fixed by #1680

Comments

@WilcoFiers
Copy link
Member

I haven't checked them all but at least passed example 1 and 3 should have audio. But this does not seem to be the case:
https://act-rules.github.io/rules/1ec09b

@ajanec01
Copy link
Collaborator

I get audio on my iPhone. I think that falls under the accessibility support section. I had the same concern for video element visual content has audio description, as in, it did not want to work in Firefox and Chrome on desktop.

@WilcoFiers
Copy link
Member Author

Interesting! But then is it a problem with one of the source files, or is it in the browser?

@ajanec01
Copy link
Collaborator

ajanec01 commented May 26, 2021

My suspicion- browsers. Maybe it would be good to park those rules (meaning not to publish as proposed) until we test it thoroughly across browsers and write a more descriptive accessibility support section?

@kengdoj
Copy link
Collaborator

kengdoj commented May 26, 2021

I can hear audio in Passed 1 and 3 in Edge. (But not in Chrome.)

I hear audio in Passed Ex 2, but do not hear audio descriptions. Same for Failed Ex 2.

@tbostic32
Copy link
Collaborator

tbostic32 commented Jun 20, 2021

Currently investigating this, after a bit of digging, it seems that the rabbit video file that works uses the audio codec MPEG AAC Audio while the others that are failing use A52 (AC3) Audio.

I haven't had a chance to determine all of the files that have this, but I was able to confirm that converting to the MPEG AAC Audio format does fix the issue at least for Firefox. .

@tbostic32
Copy link
Collaborator

See the pull request above. One thing I also noticed was that several of the videos were 720p while others were just 240p or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants