Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should "Link has non-empty name" apply to inheriting links? [c487ae] #1670

Closed
WilcoFiers opened this issue Jul 20, 2021 · 2 comments · Fixed by #1760
Closed

Should "Link has non-empty name" apply to inheriting links? [c487ae] #1670

WilcoFiers opened this issue Jul 20, 2021 · 2 comments · Fixed by #1760
Assignees

Comments

@WilcoFiers
Copy link
Member

I noticed this rule applies to semantic links. Seems to me this should also apply to inheriting semantic links.

On the other hand though, should we expect anyone testing HTML to support DPUB? Should that be in a separate rule?

@Jym77
Copy link
Collaborator

Jym77 commented Aug 19, 2021

Maybe we can have a failing example with <span role="doc-biblioref link"> so that:

  • tools that don't support DPUB fail that as being a semantic link without name;
  • tools that support DPUB and correctly check for non-empty name of inheriting semantic links fail that;
  • tools that support DPUB but only check for non-empty name of semantic links (non inheriting ones) incorrectly pass that.

That way, tools that don't fail the example are tools that do not correctly implement the rule within their ARIA capacities; and we don't "punish" tools that chose to ignore DPUB.

@WilcoFiers
Copy link
Member Author

The role attribute has valid value rule already has an example that requires support for DPUB. That suggests we shouldn't limit our rules to wai-aria proper here either. Discussed on the call, group agrees adding these roles to the rule would be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants