Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ARIA state or property is permitted [5c01ea]: clarified global property is allowed except when prohibited and added examples #2192

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Collaborator

@giacomo-petri giacomo-petri commented May 13, 2024

Closes: #2191

Updates:

  • I've amended examples like "The aria-label property is a global property. It is allowed on any semantic role," adding "except where specifically prohibited". This clarification was necessary because certain semantic roles, such as caption, code, deletion, emphasis, generic, insertion, paragraph, presentation, strong, subscript, and superscript, prohibit the use of aria-label.
  • I've included a passed example demonstrating the inheritance of properties from a superclass role, as it was absent.
  • I've included a failed example showcasing a prohibited global property to underscore the significance of the edit mentioned in the first bullet point.
  • I've included an interesting example (both passing and failing) of the separator role, illustrating that it supports a specific property when focusable but not when static.

Need for Call for Review:
This will require a 2 weeks Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants