Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the naming convention for rule files? #470

Closed
jeeyyy opened this issue Apr 10, 2019 · 1 comment
Closed

What is the naming convention for rule files? #470

jeeyyy opened this issue Apr 10, 2019 · 1 comment
Assignees
@jeeyyy
Labels
Agenda item

Comments

@jeeyyy
Copy link
Collaborator

jeeyyy commented Apr 10, 2019

In some places we give rule files a complete human readable name and in other places we generate a 6 character sha, unsure which one works better.

See - https://github.com/auto-wcag/auto-wcag/pull/416/files#diff-300c950393b60709c0c304906c118f5d for example.
@jeeyyy jeeyyy mentioned this issue Apr 16, 2019
Merged
@jeeyyy jeeyyy self-assigned this Apr 25, 2019
@jeeyyy jeeyyy mentioned this issue Apr 25, 2019
Merged
@jeeyyy jeeyyy added the Chore label Apr 25, 2019
@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Apr 29, 2019

PR has been merged. Closing.

@jeeyyy jeeyyy closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
Agenda item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeeyyy