Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run node doesn't fail fast on Linux and macOS #10

Closed
sebastianrath opened this issue Jan 3, 2024 · 0 comments · Fixed by #11
Closed

Run node doesn't fail fast on Linux and macOS #10

sebastianrath opened this issue Jan 3, 2024 · 0 comments · Fixed by #11
Assignees
Labels
bug Something isn't working

Comments

@sebastianrath
Copy link
Member

The Run node doesn't fail fast, meaning a multiline script is fully executed although a single command might fail. This behaviour is only enabled on Windows.

if runtime.GOOS == "windows" {
cmdArgs = append(cmdArgs, "--noprofile", "--norc", "-eo", "pipefail", tmpfileName)
} else {
cmdArgs = append(cmdArgs, "-e", tmpfileName)
}

man bash

pipefail

If set, the return value of a pipeline is the value of the last (rightmost) command to exit with a non-zero status, or zero if all commands in the pipeline exit successfully. This option is disabled by default.

@sebastianrath sebastianrath added the bug Something isn't working label Jan 3, 2024
@sebastianrath sebastianrath self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant