Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 #29

Closed
Gerst20051 opened this issue Sep 22, 2017 · 2 comments
Closed

Swift 4 #29

Gerst20051 opened this issue Sep 22, 2017 · 2 comments

Comments

@Gerst20051
Copy link

Gerst20051 commented Sep 22, 2017

Any updates on the progress to update this for Swift 4?

ActionKit.swift:118:30: Instance method 'append' expects a single parameter of type '(String, ActionKitClosure)'

gestureArr.append(name, closure) should be gestureArr.append((name, closure))

@coolbnjmn
Copy link
Contributor

I'm not sure about the second part of your issue.

As far as Swift 4, I'm happy to accept a PR to support Swift 4, but since Xcode9 fully supports Swift 3, I don't see a need for it right away.

@coolbnjmn
Copy link
Contributor

Turns out @brandons opened a PR, and I happily just merged it for ActionKit version 2.1

Swift 3.2 branch incoming, for backwards compatibility should that be desired. I hope this answers your issue, and I will be closing this now, please feel free to open another one if you have any issues!

Thanks again for reporting this @Gerst20051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants