Outline despite of outline=0

[jdamboeck]

Outline despite of outline=0.. also what is this glow around the windows?

oomox 1.5 arch

[actionless]

1. outline is a border which is displayed over an item selected with keyboard (with <Tab> key)

2. glow is inverted shadow (for dark themes)

[jdamboeck]

Yeah... I know what an outline is. But I disabled the outline then why is it still there.
As for the shadow, there should be a switch to just keep it as a shadow instead of a glow with dark themes.

[actionless]

1. could you highlight the mistaken outline on your screenshot?

2. i'll be happy to merge such change

[jdamboeck]

1. Okay.. I made a mistake.. there is an option focused outline width. i thought it relates to the window border but its the selected item in other elements.

but there is another error.

see the attached screens:

2. That would be really great

[actionless]

does the problem happens only with Telegram (and other google-chrome/electron-based apps) ?

if so -- that could be a duplicate of this issue:
#121 (Slack in that ticket AFAIK is using electron)

[jdamboeck]

it happens with all windows that use a small window decoration(tool style window i think). gimp for example or the oomox popup when you export the theme.

[actionless]

i still can't reproduce it but let's try to debug it:

1. is it displayed fine if gtk theme set to oomox but WM decorations theme is different?
   and if the opposite?

2. which WM do you use?

3. create a file ~/.config/gtk-3.0/gtk.css and put there:

window decoration {
	margin: 0;
	border: none;
}

restar the app and see if it helped

[jdamboeck]

1. i cant change my WM decorations.
2. i am using gnome 3.26.2
3. stays the same

[jdamboeck]

3. Okay.. After login back the faulty outline is gnone... but the outline that stays is always the focused window border color.

[jdamboeck]

and... when i change the border color... the faulty border on all tool style windows stays the same color as before. so i think there maybe an bug when applying the color to those windows.
also the courner rounding on those windows does not change.

before(retro/c64) :

after(retro/c64 modified border color and radius) :

the square is the default border color and radius
the circle is after changing it from the default state

[actionless]

i cant change my WM decorations.

if your WM not offering such option you can create a "fake" theme:

1. generate oomox theme normally
2. remove metacity-1 directory from the generated theme
3. copy that directory from some other non-oomox theme

[actionless]

and... when i change the border color... the faulty border on all tool style windows stays the same color as before. so i think there maybe an bug when applying the color to those windows.

are they applying after re-logging-in to the gnome?

[jdamboeck]

are they applying after re-logging-in to the gnome?

ah.. yes they do but its still the wrong color... always the focused window corder even if unfocused

[jdamboeck]

As for the metacity theme... i think gnome does not use that anymore?
most of my themes have no metacity folder. also if i delete that folder everything is still as intended

[actionless]

so, just to confirm it's not using metacity:

when you're doing this sequence:

1. change to some other theme
2. remove metacity-1 from oomox theme
3. choose back oomox theme
4. relogin to gnome

you're still able to reproduce the issue or you're seeing some default Adwaita titlebars?

[jdamboeck]

yes... but i can't resize the windows with csd anymore(okay.. this is because of your gtk.css changes) the buggy windows stay the same

so indeed it is using a metacity theme.
ill try adding MetacityTheme=Arc to the index.theme file

[jdamboeck]

okay.. no matter what i change it stays visually the same

[actionless]

then i guess now gnome is reading them from gtk theme

does editing ./oomox/plugins/theme_oomox/gtk-theme/src/gtk-3.20/scss/widgets/_window.scss have any effect for the issue? because there i don't see any separate handling of CSD and non-CSD windows, while on your screenshots i see what CSD and non-CSD windows have slightly different decorations (so i've suggested what on non-CSD windows metacity being used)

[jdamboeck]

for that i would have to compile it myself i think?

[actionless]

you can just edit /opt/oomox/plugins/theme_oomox/gtk-theme/src/gtk-3.20/scss/widgets/_window.scss with sudo

[jdamboeck]

nevermind... checked the source out. nothing to compile i think.

[actionless]

i particularly recommend playing with the line 40 (.ssd) or you can do it in your ~/.config/gtk-3.0/gtk.css

i think that .ssd class is being used by gnome for non-CSD windows

so _window.scss is clearly missing something for unfocused .ssd windows, i am wondering if gnome understands something like .ssd:backdrop

[jdamboeck]

changing .ssd does indeed change the windows in question... now im on the hunt for any documentation on that.. but good luck searching for searches with ssd as a term :D

[jdamboeck]

that did the trick

.ssd & {
    box-shadow: 0 0 0 1px $wm_border_focused;
    &:backdrop {
        box-shadow: 0 0 0 1px $wm_border_unfocused;
     }
}

[jdamboeck]

but the issue #121 is still there.. it applies the right color but there is a double border. the one from the ssd and inside that another one which does not include the titlebar.
with csd there are also 2 borders... but they include the window title too.

[actionless]

if you set window decoration { border-width: 0; } it looks fine but mouse not resizing the edges?

[jdamboeck]

yes

[actionless]

you need to compile in your head that scss snippet into css using the real values from your preset :-)

[actionless]

should look like that:

[jdamboeck]

ah lol.. .. where do i put that?

[actionless]

i mean replace $roundness and and $spacing to real values and compute the math, so it will be css in the end, and put to gtk.css to try

[jdamboeck]

get's even worse

[actionless]

weird, in my case the second border is the same color as titlebar

[actionless]

btw, the green border on your screenshot is not draggable anywhere, not even around titlebar?

[jdamboeck]

but your screen is not ssd... and the draggable part is only with csd windows and with the latest edit in gtk.css its draggable again.. because there is a border to drag.

[jdamboeck]

i have a spacing of 3 and a roundness of 0
so my gtk.css is now:

window` decoration {
	margin: 0;
	border-width: 5px;
}

window {
	border-radius: 0;
}

[actionless]

hm, mb i'll have a look how that part implemented in other themes

[jdamboeck]

if i pick a default color presets and export it, i too get the same color as the titlebar... when i edit "focused window border" "unfocused window border" and "background" the strange double border is back again.

somehow the wrong color gets added if you edit one of the default presets. but unedited the default color presets generate themes as they should be.

edit: bit its not consistent either. sometimes it works sometimes the error is back. might depend on the colors?

maybe it helps if i send you the preset where its broken so you can test with that?

named it .txt so i can upload it to github
brainiac.txt

[actionless]

that black color is coming from WM_BORDER_UNFOCUS=000000

[jdamboeck]

Yeah but why.

[jdamboeck]

https://www.reddit.com/r/archlinux/comments/6duktu/adding_colored_window_borders_in_gnome/di9htfj/

if i put that part in my gtk.css it works as intended. maybe it helps finding a solution.

[actionless]

could you please check if the same theme still works fine in openbox?
last time when i was playing with i remember what it was working either in one place or in another.
so if it will be like that again -- mb we can have to _window.scss files and choose one for gnome or for the rest as oomox export option

[jdamboeck]

in openbox all is as intended

[actionless]

splendid! could you prepare a pull request please?

[jdamboeck]

what for? i did not do anything... maybe we did missunderstand each other? the theme works in openbox without me doing any changes.

[actionless]

if i put that part in my gtk.css it works as intended
in openbox all is as intended

[jdamboeck]

yeah.. but i don't really know where to apply the gtk.css changes to the oomox -gtk-theme code. never done any real gtk theming before. :D I am just trying do sherlock my way through it.

[actionless]

you can see similar class names in _window.scss which i mentioned few times above

if you'll not manage to do so, i'll have some time mb on sunday to give it a try

[jdamboeck]

I will try to sherlock some more... Maybe I'll get my feet in it.

[actionless]

after that you could add SCSS to your CV ;P

[jdamboeck]

i got scss partially... i am an webdev after all but done mostly plain css and less the last years. but i don't really know the gtk specific parts in all of this.

[actionless]

i am not sure if it's solved in all the setups or not so better will leave it open

[actionless]

moved to themix-project/oomox-gtk-theme#52