Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Action seems to ignore rust-toolchain files #123

Closed
2 of 3 tasks
jack-signal opened this issue Nov 9, 2020 · 2 comments
Closed
2 of 3 tasks

Action seems to ignore rust-toolchain files #123

jack-signal opened this issue Nov 9, 2020 · 2 comments
Labels
invalid This doesn't seem right

Comments

@jack-signal
Copy link

Do the checklist before filing an issue:

Description

It does not seem that rust-toolchain files are read.

Workflow code

https://github.com/jack-signal/gh-actions-test/blob/5666895d3ee0ca51506901b09d6d94a8758e8e9a/.github/workflows/rust.yml

Relevant part

    - name: Install nightly rust
      uses: actions-rs/toolchain@v1
      with:
        profile: minimal
        components: rustfmt, clippy

Action output

Full log with debug on here https://github.com/jack-signal/gh-actions-test/runs/1376041496

##[debug]Evaluating condition for step: 'Install nightly rust'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Install nightly rust
##[debug]Loading inputs
##[debug]Loading env
Run actions-rs/toolchain@v1
  with:
    profile: minimal
    components: rustfmt, clippy
    default: false
    override: false
  env:
    CARGO_TERM_COLOR: always
Error: toolchain input was not given and repository does not have a rust-toolchain file
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Install nightly rust

Expected behavior

The problem here is - the repository does have a rust-toolchain file in the root directory, so I would expect that it would be used.

@svartalf
Copy link
Member

svartalf commented Nov 9, 2020

Hi, @jack-signal! You still need to check out your code first, otherwise there are no files at all at the working directory.

Please, see actions/checkout@v2 line at the example workflow and to GH Actions documentation

@jack-signal
Copy link
Author

Oh my gosh I can't believe I missed that, thank you.

@svartalf svartalf added invalid This doesn't seem right and removed bug Something isn't working labels Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Development

No branches or pull requests

2 participants