Fix RunerSet managed runner pods to terminate more gracefully #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
commented
Feb 17, 2022
| // - (false, nil) when the runner has been already unregistered. | ||
| // - (false, err) when it postponed unregistration due to the runner being busy, or it tried to unregister the runner but failed due to | ||
| // an error returned by GitHub API. | ||
| func unregisterRunner(ctx context.Context, client *github.Client, enterprise, org, repo, name string) (bool, error) { |
There was a problem hiding this comment.
This function is derived from RunnerReconciler's unregisterRunner function which was problem-free.
We now use this from the runner controller (a counter-part of RunnerDeployment controller) and the runner pod controller (which is a counter-part of RunnerSet controller) to make runnsetset-managed runners as reliable as runnerdeployment's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make RunnerSet-managed runners as reliable as RunnerDeployment-managed runners.
Ref #911 (comment)