Set UserAgent to actions-runner-controller for all Http Client.
#1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find any requests made by user agent
actions-runner-controllerin GitHub.com's telemetry in the past 7 days.Turns out we only set user agent
actions-runner-controllerif we are configured to use BasicAuth which is not the case for most customers I think.I update the code a little bit to make sure it always set
actions-runner-controlleras UserAgent for the GitHub HttpClient in ARC.A further step would be somehow baking the ARC release version into the UserAgent as well. 馃槃