Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme doc for The helm command for webhook installation #1188

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

yourmoonlight
Copy link
Contributor

The helm command for webhook installation is not working should be fixed

The cmd from readme doc should be working fine by directly copy and paste

@iniinikoski
Copy link

Hi @yourmoonlight! :)

Just happened to bump into the same one earlier today - cool!

Some comments:

  1. I guess a single "set" could be enough?
  2. I noticed (as a MacOS and zsh user) - that I had to also add quotes around the set, like this:

helm upgrade --install --namespace actions-runner-system --create-namespace \
             --wait actions-runner-controller actions-runner-controller/actions-runner-controller \
             --set "githubWebhookServer.enabled=true,githubWebhookServer.ports[0].nodePort=33080"

as otherwise zsh was unhappy...

@yourmoonlight
Copy link
Contributor Author

@yourmoonlight
Copy link
Contributor Author

Hi @yourmoonlight! :)

Just happened to bump into the same one earlier today - cool!

Some comments:

  1. I guess a single "set" could be enough?
  2. I noticed (as a MacOS and zsh user) - that I had to also add quotes around the set, like this:

helm upgrade --install --namespace actions-runner-system --create-namespace \
             --wait actions-runner-controller actions-runner-controller/actions-runner-controller \
             --set "githubWebhookServer.enabled=true,githubWebhookServer.ports[0].nodePort=33080"

as otherwise zsh was unhappy...

Cool, thanks for your reply, I will update it.

Copy link
Collaborator

@toast-gear toast-gear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers pal

@toast-gear toast-gear merged commit 132faa1 into actions:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants