Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unit tests were very broken + use run.sh #1244

Merged
merged 8 commits into from
Mar 22, 2022
Merged

fix: unit tests were very broken + use run.sh #1244

merged 8 commits into from
Mar 22, 2022

Conversation

toast-gear
Copy link
Collaborator

@toast-gear toast-gear commented Mar 18, 2022 •
edited

@toast-gear toast-gear changed the title fix: unit tests were very broken fix: unit tests were very broken + use run.sh Mar 18, 2022
@toast-gear
Copy link
Collaborator Author

This is good enough for now. Now the unit tests are fixed and are more readable and better documented we need to actually test that the run.sh doesn't break anything and that we no longer need our patched runner files.

@toast-gear toast-gear marked this pull request as ready for review March 21, 2022 08:13
mumoshu
mumoshu approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your awesome work ☺️

@toast-gear toast-gear merged commit 2cb04dd into master Mar 22, 2022
@toast-gear toast-gear deleted the fix/entrypoint_unit_tests branch March 22, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the new container friendly run.sh file
2 participants
@toast-gear @mumoshu