Prevent runner controller from recreating runner pod when terminated externally #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minated externally
mumoshu
changed the title
toast-gear
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was running E2E tests, I discovered an issue which resulted in some (unexpectedly recreated) runners grabbing jobs from GitHub Actions and being killed prematurely by ARC, when the pod was deleted directly, not via the parent runner resource.
You don't usually delete runner pods directly. Neither deletion of RunnerDeployment, Runner, nor RunnetSet triggers this scenario. However, this change should be useful when the pods can get deleted externally, for example, as a part of cluster-autoscaler's node termination process.
This was tested locally in my local branch that contains both this and #1759.