Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of Helm chart #187

Merged
merged 7 commits into from
Nov 14, 2020
Merged

Initial version of Helm chart #187

merged 7 commits into from
Nov 14, 2020

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Nov 14, 2020

The initial commit contains the result of helm create only.
I'll add several commits before merging so that it can be a foundation for further collaboration.

NOTES:

  • diff --unified <(helm template --include-crds actions-runner-controller charts/actions-runner-controller -n actions-runner-system | kubectl sort-manifests -f -) <(cat release/actions-runner-controller.yaml | kubectl sort-manifests -f -) | less is handy to check for differences between the official manifests and the helm chart template output.
  • You can run ACCEPTANCE_TEST_DEPLOYMENT_TOOL=helm make acceptance to run the same set of tests we run against the official manifests, but with the chart.

Ref #184

Inspired by #91

Related #61

@mumoshu
Copy link
Collaborator Author

mumoshu commented Nov 14, 2020

Whoa, it seems working

❯ helm list -n actions-runner-system
NAME                            NAMESPACE               REVISION        UPDATED                                    STATUS          CHART                           APP VERSION
actions-runner-controller       actions-runner-system   1               2020-11-14 21:48:58.773353 +0900 JST       deployed        actions-runner-controller-0.1.0 0.11.2     

❯ k -n actions-runner-system get deploy
NAME                        READY   UP-TO-DATE   AVAILABLE   AGE
actions-runner-controller   1/1     1            1           3m37s

❯ k get runnerdeployment
NAME                   DESIRED   CURRENT   READY
example-runnerdeploy   1                   

❯ k get po
NAME                               READY   STATUS    RESTARTS   AGE
example-runnerdeploy-ndr5s-rrwwh   2/2     Running   0          2m59s

@mumoshu mumoshu changed the title Start collaborating to develop a Helm chart Initial version of Helm chart Nov 14, 2020
@ClenchPaign
Copy link

ClenchPaign commented Dec 24, 2021

Whoa, it seems working

❯ helm list -n actions-runner-system
NAME                            NAMESPACE               REVISION        UPDATED                                    STATUS          CHART                           APP VERSION
actions-runner-controller       actions-runner-system   1               2020-11-14 21:48:58.773353 +0900 JST       deployed        actions-runner-controller-0.1.0 0.11.2     

❯ k -n actions-runner-system get deploy
NAME                        READY   UP-TO-DATE   AVAILABLE   AGE
actions-runner-controller   1/1     1            1           3m37s

❯ k get runnerdeployment
NAME                   DESIRED   CURRENT   READY
example-runnerdeploy   1                   

❯ k get po
NAME                               READY   STATUS    RESTARTS   AGE
example-runnerdeploy-ndr5s-rrwwh   2/2     Running   0          2m59s

Is it possible to create the runner deployment from this helm chart?

@mumoshu
Copy link
Collaborator Author

mumoshu commented Dec 24, 2021

Nope. I believe it's a standard helm chart convention to separate k8s operator deployment and custom resource deployment. You'd need to create your own chart, or just use incubator/raw to deploy arbitrary resources including RunnerDeployment, or just use kubectl for simple resources.

@mumoshu
Copy link
Collaborator Author

mumoshu commented Dec 24, 2021

Sorry but I'm locking this issue to prevent random questions to outdated pull requests and issues. It happens often and it's a maintenance nightmare from maintainer's perspective!

FYI, there's another issue that asked exactly what you want, and I think I've replied with a similar answer there. See that issue for more context.

@actions actions locked as resolved and limited conversation to collaborators Dec 24, 2021
@mumoshu
Copy link
Collaborator Author

mumoshu commented Dec 24, 2021

@ClenchPaign I spent 10 minutes searching for the issue but I couldn't find one.

Perhaps it was just that I was asked about a chart for RunnerDeployments in some random issue unrelated to the chart? 🤔

Anyway, I'd suggest you create a dedicated issue for that, so that we could at least enhance our chart README to note that it doesn't support managing RunnerDeployments. Or even better, anyone from the community could chime in and introduce another chart for managing RunnerDeployments!

Thanks in advance for your cooperation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants