-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of Helm chart #187
Conversation
Whoa, it seems working
|
Is it possible to create the runner deployment from this helm chart? |
Nope. I believe it's a standard helm chart convention to separate k8s operator deployment and custom resource deployment. You'd need to create your own chart, or just use |
Sorry but I'm locking this issue to prevent random questions to outdated pull requests and issues. It happens often and it's a maintenance nightmare from maintainer's perspective! FYI, there's another issue that asked exactly what you want, and I think I've replied with a similar answer there. See that issue for more context. |
@ClenchPaign I spent 10 minutes searching for the issue but I couldn't find one. Perhaps it was just that I was asked about a chart for RunnerDeployments in some random issue unrelated to the chart? 🤔 Anyway, I'd suggest you create a dedicated issue for that, so that we could at least enhance our chart README to note that it doesn't support managing RunnerDeployments. Or even better, anyone from the community could chime in and introduce another chart for managing RunnerDeployments! Thanks in advance for your cooperation. |
The initial commit contains the result of
helm create
only.I'll add several commits before merging so that it can be a foundation for further collaboration.
NOTES:
diff --unified <(helm template --include-crds actions-runner-controller charts/actions-runner-controller -n actions-runner-system | kubectl sort-manifests -f -) <(cat release/actions-runner-controller.yaml | kubectl sort-manifests -f -) | less
is handy to check for differences between the official manifests and the helm chart template output.ACCEPTANCE_TEST_DEPLOYMENT_TOOL=helm make acceptance
to run the same set of tests we run against the official manifests, but with the chart.Ref #184
Inspired by #91
Related #61