Added support to enable and disable enableServiceLinks.

[sxd]

This option expose internally some KUBERNETES_* environment variables
that doesn't allow the runner to use KinD (Kubernetes in Docker) since it will
try to connect to the Kubernetes cluster where the runner it's running.

This option it's set by default to true in any Kubernetes deployment.

For more information on this option you can visit:
https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/#accessing-the-service

This fix #626 by adding the option to control the behavior

Signed-off-by: Jonathan Gonzalez V jonathan.abdiel@gmail.com

[mumoshu]

@sxd Thanks a lot for your efforts!

To be extra sure, the workaround is to unset all the KUBERNETES_* envvars before running kind and kubectl, right?

And this patch makes the workaround unnecessary, while making the use of https://github.com/helm/kind-action possible as the workaround doesn't work for kind-action because you can't unset envvars that kind-action reads?

[sxd]

@mumoshu exactly! that's exactly what this fix =) please let me know if you need more information! =)

[toast-gear]

Thank for the PR, we are going to hold off merging this whilst #629 is being developed

[sxd]

@toast-gear There's anything I can do to help with this? just to speed up the merge, can I help with something on #629 ?

Regards!

[toast-gear]

Test test test! It's difficult to do full CI testing due to the project being as open source as you can get (i.e. no money for infrastructure) so the more people can test the new stateful runners in a diverse set of scenarios the quicker we can merge it

[mumoshu]

#629 has been merged and I've resolved the conflict happened on this PR. Let's merge and see how it goes! Thanks again for your contribution @sxd ☺️