Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchain file not properly overriden #31

Closed
fprasx opened this issue Jan 12, 2024 · 2 comments · Fixed by #33
Closed

toolchain file not properly overriden #31

fprasx opened this issue Jan 12, 2024 · 2 comments · Fixed by #33
Labels
bug Something isn't working

Comments

@fprasx
Copy link
Contributor

fprasx commented Jan 12, 2024 •
edited
Loading

Related: #26 #28

It seems like the fix from #30 does not properly override the toolchain specified by rust-toolchain.toml. Using rustup override set $TOOLCHAIN instead of rustup default $TOOLCHAIN seems to do the trick:
Screenshot 2024-01-12 at 12 25 08 PM

I can make a PR if this seems like a desirable fix.
@fprasx fprasx mentioned this issue Jan 12, 2024
Merged
@robjtede
Copy link
Contributor

Good catch! Seems reasonable, I'd approve a PR for this suggested fix 👍🏻

@robjtede robjtede added the bug Something isn't working label Jan 12, 2024
@fprasx fprasx mentioned this issue Jan 12, 2024
Merged
@fprasx
Copy link
Contributor Author

fprasx commented Jan 12, 2024

Sounds good: see #33.

@jonasbb jonasbb mentioned this issue May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use rustup override set to select toolchain fprasx/setup-rust-toolchain
2 participants
@robjtede @fprasx