Listener imagePullPolicy will no longer be inherited from the controller manager as of gha-runner-scale-set-0.7.0

[nikola-jokic]

In gha-runner-scale-set-0.6.0 we introduced the ability to configure the listener pod spec via the listenerTemplate in charts/gha-runner-scale-set. Before this release, the imagePullPolicy was inherited from the configuration of the controller manager pod and used for every autoscaling listener.

With the ability to update the spec of any autoscaling listener pod, we are removing the dependency of the listener pods on the imagePullPolicy of the controller manager.

How does this change affect me?

If you upgraded to gha-runner-scale-set-0.6.0 and configured the imagePullPolicy in the listenerTemplate object for your listener, this value will be ignored and we will use the imagePullPolicy field, if it has been specified in the controller chart. This is to maintain temporary backward compatibility until everyone has had the chance to upgrade.

Otherwise, we will fall back to the controller manager imagePullPolicy value.

Cluster administrators will get a deprecation warning through helm.

What happens after gha-runner-scale-set-0.7.0?

The imagePullPolicy will only be applied to the listener pod if the listenerTemplate specifies it.

Otherwise, it will be left unspecified, and will apply the default Kubernetes behaviour. The imagePullPolicy field is specified in the controller chart will not be applied to the listener pod.

If you depend on this field, make sure you update your listenerTemplate object to explicitly specify the imagePullPolicy for the listener.