Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the Runner terminates, refer to why the Runner terminated and suppress the addition of EphemeralRunner to the failure. #2722

Closed
kahirokunn opened this issue Jul 6, 2023 · 1 comment
Closed

When the Runner terminates, refer to why the Runner terminated and suppress the addition of EphemeralRunner to the failure. #2722

kahirokunn opened this issue Jul 6, 2023 · 1 comment
Labels
enhancement New feature or request gha-runner-scale-set Related to the gha-runner-scale-set mode

Comments

@kahirokunn
Copy link
Contributor

What would you like added?

If the runner starts successfully, waits for a job successfully, and exits when the job is not being processed, how about not adding it to the failure list?

Why is this needed?

RUNNER was started on a SPOT instance with minRunners at 1.
Each time the spot instance terminates, the runner naturally terminates as well.
When runner terminates, a failure is added to EphemeralRunner.
Because of this, I cannot make the runner reside on the spot instance.

Additional context

#2721
@kahirokunn kahirokunn added enhancement New feature or request needs triage Requires review from the maintainers labels Jul 6, 2023
@kahirokunn kahirokunn mentioned this issue Jul 6, 2023
Open
@nikola-jokic nikola-jokic added gha-runner-scale-set Related to the gha-runner-scale-set mode and removed needs triage Requires review from the maintainers labels Jul 14, 2023
@nikola-jokic
Copy link
Contributor

Let's close this issue since it is decided not to make it work on spot instances, at least for now ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kahirokunn @nikola-jokic