Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting whitelisting CVE's / Dependencies #133

Closed
AtzeDeVries opened this issue Jun 27, 2022 · 6 comments · Fixed by #251
Closed

Supporting whitelisting CVE's / Dependencies #133

AtzeDeVries opened this issue Jun 27, 2022 · 6 comments · Fixed by #251
Labels
enhancement New feature or request

Comments

@AtzeDeVries
Copy link

It would be nice to be able to ignore / whitelist certain dependencies. This way we can keep working if no fix exist yet/

@febuiles
Copy link
Contributor

@AtzeDeVries this sounds like something we could do in a future. What format do you envision to specify the dependencies?

@AtzeDeVries
Copy link
Author

I thought about having some config which sits with the code (so not in .github dir) which contains a whitelist (or ignorelist) which at least contains

  • CVE
    Possible also
  • End date until whitelist is valid (so required a review after x months)

And also i don't now how the CVE's on dependencies work, but i guess CVE's on a dependency can also be updated (added text, change of severity) so it would be nice to link the ignore a certain version of the CVE.

@febuiles
Copy link
Contributor

We'll likely move our config options (licenses and allow/denylist) to an external config file in the upcoming months to make this Action easier to install in big organizations. Will take a look at this when we do the migration.

@AtzeDeVries
Copy link
Author

Thnx for taking a look at it!

@LiuVII
Copy link

LiuVII commented Jul 14, 2022

I don't see how this can be fully utilized without whitelisting really, looks like a must for anything beyond the MVP phase.
Is there some workaround in a meantime at least?

upd: well, maybe the GHA check can't be enforced really without whitelisting is what I mean, the action itself is pretty useful as it is 🙂 but making this check required would be really nice

@febuiles
Copy link
Contributor

@LiuVII what do you think about adding a new config option (a list called ignore?) that is checked against the advisory_ghsa_id field of the API response? We don't receive CVEs in the API response, hence the fallback to GHSA ids.

If you need help getting a PR started please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants