Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the value none as the possible values for the fail-on-severity parameter #431

Closed
tgrall opened this issue Mar 18, 2023 · 1 comment · Fixed by #432 · May be fixed by soloinovator/dependency-review-action#34
Closed
Labels
enhancement New feature or request

Comments

@tgrall
Copy link
Contributor

tgrall commented Mar 18, 2023

Add the value none as the possible values for the fail-on-severity parameter

Problem

  • It would be useful to provide a parameter to the action that will only list all the anomalies and do not fail
  • The idea is to match one of the none value that can be used in the "Code Scanning" options

Solution

  • Add the value none as the possible values for the fail-on-severity parameter
  • when set to none the action will:
    • not block the PR (raise an alert) in one or more vulnerabilities, or invalid licences are found
    • a warning will be publish
    • all alerts will be printed in the summary (vulnerabilities & licences)
  • Default behaviour is not changed and the value is set to low
@felickz
Copy link
Contributor

felickz commented Nov 21, 2023

This would be a great enhancement as today you need to set the fail scenario to see any CVE data in the action. This can be important information to have at hand even if you are not wanting to fail the workflow.

Further example: we might want to warn on dev dependency scoped fail-on-scopes but fail on runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants