Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows-latest 20220626.1: regression ThreadSanitizer failed to allocate... with go test -race #5841

Closed
2 of 10 tasks
mark-pictor-csec opened this issue Jun 28, 2022 · 3 comments
Assignees
Labels
bug report external investigate Collect additional information, like space on disk, other tool incompatibilities etc. OS: Windows

Comments

@mark-pictor-csec
Copy link

Description

Something in the latest win22 image (win22/20220626.1) is causing a regression. This is not seen with the previous image (win22/20220614.0).

The errors seen are of the form

==5248==ERROR: ThreadSanitizer failed to allocate 0x0000019b9000 (26972160) bytes at 0x200d965c00000 (error code: 87)

while running

go test -v ./... -race -coverprofile=coverage.txt -covermode=atomic

Something similar has been seen by other people, and I suspect the cause is the same: tailscale/tailscale#4926, gobuffalo/.github#2

Platforms affected

  • Azure DevOps
  • GitHub Actions

Virtual environments affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 10.15
  • macOS 11
  • macOS 12
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

failed image https://github.com/actions/virtual-environments/releases/tag/win22%2F20220626.1
failed build https://github.com/Contrast-Security-OSS/go-test-bench/runs/7101854784?check_suite_focus=true#step:4:105

working image https://github.com/actions/virtual-environments/releases/tag/win22%2F20220614.0
working build https://github.com/Contrast-Security-OSS/go-test-bench/runs/6992890616?check_suite_focus=true#step:4:620

Is it regression?

yes

Expected behavior

the build to pass, or at least to fail for reasons under our control

Actual behavior

the test run fails with errors like

==5248==ERROR: ThreadSanitizer failed to allocate 0x0000019b9000 (26972160) bytes at 0x200d965c00000 (error code: 87)

Repro steps

Re-run this job, which is the windows-latest test on our branch broken-cmd-exercise.
The workflow config can be seen at continuous-integration-workflow.yml:L29

@mark-pictor-csec
Copy link
Author

Is it possible to specify a specific image version for github actions? I didn't see it in the gh actions docs, but if it is possible it'd be a temporary workaround.

@al-cheb
Copy link
Contributor

al-cheb commented Jun 29, 2022

Hello @mark-pictor-csec.
We updated mingw in this #5729 PR to the v11.2.0 version. I have found out the same issue in golang official repo - golang/go#46099. The recommendation is to downgrade mingw to 10.2.0 in runtime - golang/go#46099 (comment)

- name: Install mingw 10.2.0
  run: choco install mingw --version 10.2.0 --allow-downgrade

image

@al-cheb al-cheb added OS: Windows investigate Collect additional information, like space on disk, other tool incompatibilities etc. external and removed needs triage labels Jun 29, 2022
@al-cheb al-cheb self-assigned this Jun 29, 2022
@al-cheb
Copy link
Contributor

al-cheb commented Jun 29, 2022

Close as external.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report external investigate Collect additional information, like space on disk, other tool incompatibilities etc. OS: Windows
Projects
None yet
Development

No branches or pull requests

2 participants