Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ninja #8348

Closed
9 of 11 tasks
mstorsjo opened this issue Sep 20, 2023 · 1 comment
Closed
9 of 11 tasks

Add ninja #8348

mstorsjo opened this issue Sep 20, 2023 · 1 comment

Comments

@mstorsjo
Copy link

Tool name

ninja

Tool license

Apache 2.0

Add or update?

  • Add
  • Update

Desired version

latest

Approximate size

200-500 KB

Brief description of tool

Ninja is a build tool, commonly used as the build tool for CMake.

This tool has been implicitly included in the windows-2022 images for a long time, installed as a transitive dependency, but after a recent update it no longer is included. (It hasn't been included on Ubuntu or macOS images though.)

I believe it would be useful to have it formally included among the tools that intentionally are installed. On Windows, including it wouldn't in the end carry more software than the image used to before anyway, as it already used to be included transitively.

While it can be installed manually, doing so is an extra unnecessary step when CMake already is available out of the box in the images, and CMake frequently is used together with Ninja.

URL for tool's homepage

https://github.com/ninja-build/ninja

Provide a basic test case to validate the tool's functionality.

No response

Platforms where you need the tool

  • Azure DevOps
  • GitHub Actions

Runner images where you need the tool

  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • macOS 13
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

No response

Tool installation time in runtime

No response

Are you willing to submit a PR?

No response

@erik-bershel
Copy link
Contributor

Hello! We understand your concerns, but our opinion on the issue has not yet changed since #4972. The instrument is extremely easy to install in runtime. I'm going to close this issue but feel free to open new in case of other concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants