Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-latest not working. getting 1.20.3 instead of 1.20.4 (forcing 1.20.4 works but defeats "check-latest") #373

Closed
2 of 5 tasks
ldemailly opened this issue May 3, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ldemailly
Copy link

Run 4d34df0
with:
go-version: 1.20
check-latest: true
token: ***
cache: true
Setup go version spec 1.20
Attempting to resolve the latest version from the manifest...
matching 1.20...
Resolved as '1.20.3'

Action version:
4d34df0
(latest)

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
1.20 wanting 1.20.4

Repro steps:
https://github.com/fortio/fortiotel/blob/main/.github/workflows/releaser.yml

Expected behavior:
1.20.4 picked

Actual behavior:
1.20.3 picked

@ldemailly ldemailly added bug Something isn't working needs triage labels May 3, 2023
@ldemailly
Copy link
Author

https://github.com/fortio/multicurl/pull/64/files did pick 1.20.4 before retrying the one above that still got 1.20.3

@dmitry-shibanov
Copy link
Contributor

Hello @ldemailly. Thank you for your report. We've updated versions-manifest.json. It should work as expected. For now I'm going to close the issue.

@ldemailly
Copy link
Author

Thanks, I didn't know this was maintained by hand.

How come that it worked when I put "1.20.4" explicitly, before your update?

@jan-xyz
Copy link

jan-xyz commented Jun 9, 2023

How come that it worked when I put "1.20.4" explicitly, before your update?

The README says

the action will search for the latest available patch version sequentially in the runner's directory with the cached tools, in the versions-manifest.json file or at the go servers.

Does that answer your question?

@ldemailly
Copy link
Author

Same now with 1.20.7 - can you please update, my CI is failing because of govulncheck flagging the security issue in 1.20.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants