Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate description of version in go.mod #461

Closed
rootulp opened this issue Mar 4, 2024 · 2 comments · Fixed by #458
Closed

Inaccurate description of version in go.mod #461

rootulp opened this issue Mar 4, 2024 · 2 comments · Fixed by #458
Assignees
@gowridurgad
Labels
bug Something isn't working

Comments

@rootulp
Copy link

rootulp commented Mar 4, 2024

Context

setup-go/README.md

Line 186 in 6c1fd22

used by a project. As the `go.mod` file contains only major and minor (e.g. 1.18) tags, the action will search for the

Problem

A go.mod can contain a Go patch version. For example, see https://github.com/celestiaorg/celestia-app/blob/630a3e97a6bc7d34b792658f9080e3e5f0d027e8/go.mod#L3

Proposal

Update the README.md
@matthewhughes-uw
Copy link

It looks like #458 addresses this

@178inaba 178inaba mentioned this issue Mar 24, 2024
Merged
@gowridurgad gowridurgad self-assigned this Mar 26, 2024
@aparnajyothi-y aparnajyothi-y added the bug Something isn't working label Apr 12, 2024
@gowridurgad
Copy link

Hello, The PR which address this issue is merged. so closed this issue.
Thank You !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gowridurgad gowridurgad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the description of the old go.mod specification 178inaba/setup-go
4 participants
@rootulp @matthewhughes-uw @aparnajyothi-y @gowridurgad