Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Semeru distribution #279

Closed
vlsi opened this issue Jan 15, 2022 · 3 comments · Fixed by #289
Closed

Support Semeru distribution #279

vlsi opened this issue Jan 15, 2022 · 3 comments · Fixed by #289
Labels
feature request New feature or request to improve the current logic

Comments

@vlsi
Copy link

vlsi commented Jan 15, 2022

Description:

Support Semeru (IBM) Java distribution. It would allow testing Java with IBM JIT.
The suggested flow:

a) distribution: 'semeru'
b) or even treat distribution: 'adopt-openj9' as an alias to semeru (and print a warning to encourage users to migrate to semeru)

Justification:

Adopt-OpenJ9 has been deprecated, and Temurin does not ship distributions with OpenJ9 JIT.
The suggestion is to use https://developer.ibm.com/languages/java/semeru-runtimes/ instead of Adopt-OpenJ9

Are you willing to submit a PR?

I might submit a PR, however, I would like to know if such a PR is desirable at all.

@vlsi vlsi added feature request New feature or request to improve the current logic needs triage labels Jan 15, 2022
@bmarwell
Copy link

Big +1. I think Alex closed his issue too early (#239 (comment)).

@dmitry-shibanov
Copy link
Contributor

Hello @vlsi. Thank you for your report. We have no objections to add this functionality. We'll appreciate if you submit a pull request.

@bmarwell
Copy link

@dmitry-shibanov I'd say you inadvertently removed the adopt-openj9 distribution by not updating its name.
You did the same with the adopt/adopt-hotspot to temurin transition. I do not understand why you would not handle the adopt-openj9 to semeru transition in a similar way and now see this as a feature request. For me this is a BIG regression instead, because out of nowhere my distribution does not get updates anymore, whereas the other distribution DOES get updates ­-- both without any announcements.

Kindly continue support both alike instead of asking for PRs -- that would be much more user-friendly. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants