Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-latest is false, but still tries to resolve latest version. Then fails and just passes without setting up the requested version #519

Open
2 of 5 tasks
kalmanbencze opened this issue Jul 28, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@kalmanbencze
Copy link

kalmanbencze commented Jul 28, 2023

Description:
image
We use v3 of the action and use it to set up adopt jdk 17. It's causing a lot of headaches that it's trying to resolve latest version, it times out and just completes without failing. There's other times where it's actually failing:
image

Task version:
v3

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
Start a matrix of 40-50 jobs all setting up java with:
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: '17'
cache: 'gradle'
It's guaranteed to happen to at least 5-6 times.

Expected behavior:
It's expected to set up java 17 from cache if check-latest: false is specified and not fail on "checking latest version" when it still needs to download it.

Actual behavior:
check-latest: false is ignored as seen in screenshot #1, and when a very frequent timeout happens, the acton passes successfully.

@kalmanbencze kalmanbencze added bug Something isn't working needs triage labels Jul 28, 2023
@kalmanbencze
Copy link
Author

kalmanbencze commented Jul 28, 2023

upgrading to 3.12.0 may have fixed the issue, I'll close this if it doesn't reproduce anymore.

Edit: I upgraded to 3.12.0 and specified 17.0.8+7 as java version but the issue still happens.

@IvanZosimov
Copy link
Contributor

Hi, @kalmanbencze 👋 Thanks for the issue, we will take a look!

@kalmanbencze kalmanbencze changed the title Check-latest is false, but still tries to resolve latest version. Then fails and just passes with a different version Check-latest is false, but still tries to resolve latest version. Then fails and just passes without setting up the requested version Jul 31, 2023
@IvanZosimov IvanZosimov self-assigned this Aug 22, 2023
@IvanZosimov
Copy link
Contributor

Hi, @kalmanbencze 👋 I tried to reproduce the issue, but unfortunately without luck. May I ask you to turn the debug mode on (link to guide how to do this can be found here) and provide us with additional information about the failed runs (links or logs would be appreciated).

@IvanZosimov
Copy link
Contributor

Just a gentle ping, @kalmanbencze 📟

@kalmanbencze
Copy link
Author

sorry I was afk for a bit, will do and report back.

@kalmanbencze
Copy link
Author

I had reproduced it with extra logs (I hope):
image
logs_136801.zip
the step is stuck at downloading jdk at 99.4% forever.

@kalmanbencze
Copy link
Author

kalmanbencze commented Sep 6, 2023

24_build (featurefamilyrewardsfamilyrewards-implementation).txt
maybe I haven't enabled the debug logging properly? I did what the guide said about adding the secret ACTIONS_RUNNER_DEBUG with true
image

@aparnajyothi-y aparnajyothi-y removed their assignment Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@kalmanbencze @IvanZosimov @aparnajyothi-y and others