-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Amazon Corretto binaries #68
Comments
Corretto member here. Looking at #67, yes, that seems to be a valid framework for us |
Would be also interested. The releases can be found in: I could imagine to contribute towards it, but we dont have any |
@dmitry-shibanov @konradpabjan any ideas how we can solve that restriction with the github api calls? Would introduce an optional github token a viable solution? |
Does Corretto provides any API except GitHub Repos API? |
why don't use foojay api which provide urls for all providers See #142 |
|
If the distro selected provides signatures (which Corretto, in this example does) and the foojay disco API provided those signatures, we can easily verify the authenticity of the binary pulled, and rule out any possibility of an intermediate party being g compromised and maliciously pointing to wrong binaries. All it will take is for setup-java to have a [statically maintained] set of known/trusted distro signers. |
According to Correto Documentation 8/11/16 it seems like the only way to access older version is github (across these 3 repos). However they provide the latest version as a permalink in following format: For example: So I guess you could construct urls to download specific versions (or latest). But as they seem to have their own versioning format you wont be able to use unspecific versions like 11.0.11 (without crawling release names before). EDIT:
@alvdavi do you know if you provide any sort of api for coretto? EDIT2: I guess fetching all tags of those repos could be a way without doing too many requests and get to know the versions. |
@benty-amzn @hyandell @cliveverghese Any input on this? 😃 |
Even if |
For the start, it would be sufficient to have the latest of 8,11,15 :) And the permalink format would work perfectly for that purpose. |
For those who are still suffering of missing Corretto11, one may use plain
Please, note |
Forgot to share our workflow. It has the advantage that its only cached, when no new verison is released. - name: Get latest Corretto URL
id: get-latest-corretto-url
run: >-
echo "::set-output name=URL::$(curl -LIs -o /dev/null -w
%{url_effective}
https://corretto.aws/downloads/latest/amazon-corretto-8-x64-linux-jdk.tar.gz)"
- uses: actions/cache@v2
id: corretto-cache
name: Restore Corretto
with:
path: ./amazon-corretto-8-x64-linux-jdk.tar.gz
key: >-
${{ runner.os }}-corretto-${{
steps.get-latest-corretto-url.outputs.URL }}
- name: Download AWS Corretto
if: steps.corretto-cache.outputs.cache-hit != 'true'
run: >-
wget
https://corretto.aws/downloads/latest/amazon-corretto-8-x64-linux-jdk.tar.gz
- name: Set up JDK 1.8
uses: actions/setup-java@v2
with:
distribution: jdkfile
java-version: '8'
architecture: x64
jdkFile: ./amazon-corretto-8-x64-linux-jdk.tar.gz EDIT: The provided link of lutkerd refers to that github page: https://corretto.github.io/corretto-downloads/ |
Corretto has published a json file that contains the latest versions and hashes of the releases. The resources in indexmap_with_checksum.json will be the latest available versions via |
I've opened up a PR (#312) to support the installation of the available major corretto versions (eg 8, 11, 15, 16, 17, 18). It uses the indexmap_with_checksum.json, which @lutkerd linked to from https://corretto.github.io/corretto-downloads/ |
hi @deki. I believe, you need to use |
Thanks, just noticed it as well and deleted the comment but you were to fast ;-) |
With work being done towards adding additional binary distributions of OpenJDK as options (likely under the "distro" option, see e.g. #67), it would be useful to include Amazon Corretto among the distro options.
The text was updated successfully, but these errors were encountered: