Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch #80

Closed
6 tasks done
andymckay opened this issue Jul 13, 2020 · 4 comments · May be fixed by Exhorder6/setup-java#5, NOUIY/setup-java#6, NOUIY/setup-java#17, NOUIY/setup-java#25 or NOUIY/setup-java#43
Closed
6 tasks done
Assignees

Comments

@andymckay
Copy link

andymckay commented Jul 13, 2020

👋 This issue is to track the move over to using main as the default branch for this repo. We’d love your team's help in completing this transition.

Do not remove your old default branch, customers are going to be using it. We will be sending messages out about these changes, but if you want to message in your repository, that's fine as well.

  • Create a main branch.
  • You might need to rebase any pull requests you want to merge before changing the default branch.
  • Change the default branch in settings to main.
  • Update any documentation in this repo to refer to the new branch name, although using the version tag is still preferred.
  • Check that this Action works correctly for users who have a repository with a custom default branch name.
  • Close this issue and celebrate 🎉

We are aiming to complete this work by July 17th July 24th.

@joschi
Copy link
Contributor

joschi commented Jul 15, 2020

@andymckay Please keep in mind that there might be some users referencing actions/java@master in their workflows and this change would break their builds. It would be great if there could be a "soft warning" phase before the actual removal of the master branch.

Maybe it would be possible to emit a warning if people were still on the master branch, for example by emitting a warning via core.warning() for a few weeks.

Unfortunately the GitHub code search doesn't yield a useful result to see how many repositories would be affected because @ is being used to tokenize the input:
Search result for language:yaml path:".github/workflows" "actions/setup-java" +master

@konradpabjan
Copy link
Collaborator

@joschi Only the default branch will be changed to main. The @master branch won't be removed any time soon (no plans at all currently), we would break ALOT of users if we did that just looking at internal telemetry.

A few first party actions have already changed to main such as upload-artifact, download-artifact and checkout. Expect no side-effects. Users tied to @master just won't get the latest updates unless they switch to @main or a specific tag.

@joschi
Copy link
Contributor

joschi commented Jul 15, 2020

@konradpabjan Thanks a lot for the clarification!

@konradpabjan
Copy link
Collaborator

I've updated the branch to main. I've merged in two PRs beforehand however there are still some big ones that have been languishing in sadness in despair and I need to find some time to try take a look at them😞 those will have to be rebased in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment