Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.7.0 is a breaking change #814

Closed
eddiemonge opened this issue Jul 18, 2023 · 5 comments
Closed

v3.7.0 is a breaking change #814

eddiemonge opened this issue Jul 18, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@eddiemonge
Copy link

Version 3.7.0 is a breaking change. Does this project follow semver? If not, I'll pin my project to use 3.6.0 until 3.7.0 is fixed (see #797 (comment)).

If this was not meant to be a breaking change, I suggest unpublishing version 3.7.0 or doing a patch version to revert functionality

@eddiemonge eddiemonge added bug Something isn't working needs triage labels Jul 18, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @eddiemonge. Thank you for your report. I think it is not a breaking change because regarding to the thread it didn't work as expected initially because of parsing logic that is why on the post step the action was getting different value.

@eddiemonge
Copy link
Author

Changing the default or expected value from null to string would seem to me to be breaking. One day my gh actions worked, and the next, they didn't, without my code changing. I would consider that a breaking change, since it had been that way all of 3.x

@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Jul 18, 2023

Could you please describe your case with changing value from null to string? Do you mean post input ? Could you please attach failed build if it is possible ?

@dmitry-shibanov
Copy link
Contributor

Hello @eddiemonge. Could you please try to use changes changes from the main branch ?

@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Aug 15, 2023

Hello @eddiemonge. The new version of setup-node was released. For now I'm going to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants