Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: no-hash option #380

Closed
PerchunPak opened this issue Apr 7, 2022 · 2 comments
Closed

Request: no-hash option #380

PerchunPak opened this issue Apr 7, 2022 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@PerchunPak
Copy link

Description:
Add no-hash option. It will disable adding hash in cache key. So instead of setup-python-{os}-python-{python_version}-{package_manager}-{hash("dependency file")} we will have setup-python-{os}-python-{version}-{package_manager} in key.

P.S. How about pass to {python_version} (from key) only major and minor versions (X.X.x), example 3.10 instead of 3.10.4?

Justification:
Whould be usefull to update dependecies instead of re-install all them again.

Are you willing to submit a PR?
Sorry, but I don't know codebase at all.

@PerchunPak PerchunPak added feature request New feature or request to improve the current logic needs triage labels Apr 7, 2022
@vsafonkin
Copy link

vsafonkin commented Apr 8, 2022

Hi @PerchunPak, we will take a look at it, thank you for your suggestion!

@dmitry-shibanov
Copy link
Contributor

Hello @PerchunPak. Thank you for your report. We would not like to implement such kind of logic, because the initial caching logic for setup-python should cover the most often use cases. If you want to use some more complex caching logic we would recommend you to use actions/cache. It's relevant to setup-node ADR.

For now I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants