Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve debug text for onlyLabels usage #395

Closed
HonkingGoose opened this issue Mar 18, 2021 · 4 comments · Fixed by #433
Closed

improve debug text for onlyLabels usage #395

HonkingGoose opened this issue Mar 18, 2021 · 4 comments · Fixed by #433

Comments

@HonkingGoose
Copy link
Contributor

HonkingGoose commented Mar 18, 2021 •
edited

Current situation

The grammar for the logging output when you use onlyLabels is:

[#9184] The option "onlyLabels" was specified to only processed the issues and pull requests with all those labels (2)

Suggestion for improvement

I think we can improve it by saying something like this:

[#9184] The option "onlyLabels" was specified so we only process issues and pull requests with all those labels (2)

Related issue(s)

#347
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Apr 18, 2021
@C0ZEN
Copy link
Contributor

C0ZEN commented Apr 18, 2021

up

@github-actions github-actions bot removed the Stale label Apr 19, 2021
@C0ZEN
Copy link
Contributor

C0ZEN commented May 5, 2021

[#9184] The option "onlyLabels" was specified to only processed issues and pull requests with all those labels (2)

I prefer this sentence because the workflow is not referred as "we" but as a "it" @HonkingGoose. WDYT?

@C0ZEN C0ZEN mentioned this issue May 5, 2021
Merged
4 tasks
@HonkingGoose
Copy link
Contributor Author

[#9184] The option "onlyLabels" was specified to only processed issues and pull requests with all those labels (2)

How about:

[#9184] The option "onlyLabels" was specified to only process issues and pull requests with all those labels (2)

So we change the word processed -> process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(logs): final overhaul of the logs C0ZEN/stale
2 participants
@C0ZEN @HonkingGoose